Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix recovery error screen during Error Recovery on desktop #15969

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Aug 12, 2024

Overview

Woops, we missed the desktop designs for this screen. Easy to do, considering this is a pretty edge-case screen to begin with.

Current

Screenshot 2024-08-12 at 1 22 45 PM

Fixed

Screenshot 2024-08-12 at 1 28 13 PM

Test Plan and Hands on Testing

  • See images

Changelog

  • Fixed button and screen sizing issues for the "recovery error" screen on desktop during Error Recovery.

Risk assessment

low

Woops, we missed the desktop designs for this screen.
@mjhuff mjhuff requested a review from a team as a code owner August 12, 2024 17:29
Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mjhuff mjhuff merged commit 3ab4773 into chore_release-8.0.0 Aug 12, 2024
20 checks passed
@mjhuff mjhuff deleted the app_fix-error-during-er-desktop-btn branch August 12, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants